Fix command to deploy the simplest operator #34
Conversation
|
This change is |
Codecov Report
@@ Coverage Diff @@
## master #34 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 16 16
Lines 599 599
=======================================
Hits 594 594
Misses 5 5Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @geoand)
CONTRIBUTING.adoc, line 52 at r2 (raw file):
[source,bash] ---- make build run
Calling build before run should not be required. Did you have problems when running run without build?
|
I did have a problem, since Thanks |
There was a problem hiding this comment.
You are absolutely correct. I just checked the Makefile and it does call the binary. A previous version probably executed go run main.go instead, which is what got me confused. Would you try just changing the Makefile to do go run main.go start instead of calling the binary and see if that works? One thing that might break is the "version" command, but other than that, it should just work.
If it works, then I'd appreciate if you could open another PR with that change alone, leaving this one without the make build run part.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @geoand)
|
@jpkrohling Sure thing, on it :) |
Signed-off-by: Georgios Andrianakis <geoand@gmail.com>
geoand
force-pushed
the
contributing-fix
branch
from
f6b71d2
to
aeef23e
Compare
geoand
changed the title
|
@jpkrohling I updated this PR to include the |
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved
Signed-off-by: Georgios Andrianakis geoand@gmail.com